Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GroupTokens to replace WelcomeTokens #24265

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 15, 2022

Overview

In conjunction with #24235

Hmm - this would make {group.title} work - but I see replaceResubscribeTokens actually concatentates several group titles together - not quite sure how we could do this to support that too ....

  public static function &replaceResubscribeTokens(
    $str, &$domain, &$groups, $html,
    $contact_id, $hash
  ) {
    if (self::token_match('resubscribe', 'group', $str)) {
      if (!empty($groups)) {
        $value = implode(', ', $groups);
        self::token_replace('resubscribe', 'group', $value, $str);
      }
    }
    return $str;
  }

@civibot
Copy link

civibot bot commented Aug 15, 2022

(Standard links)

@civibot civibot bot added the master label Aug 15, 2022
@colemanw
Copy link
Member

colemanw commented Oct 5, 2022

@eileenmcnaughton style warnings

@eileenmcnaughton
Copy link
Contributor Author

It has passed now

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 this has passed now

@seamuslee001
Copy link
Contributor

Yeh this seems sensible

@seamuslee001 seamuslee001 merged commit 27f6007 into civicrm:master Oct 28, 2022
@seamuslee001 seamuslee001 deleted the welcome branch October 28, 2022 01:18
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants