Afform - Update correct existing email,phone,address & prevent deletion of others

[colemanw]

Overview

This fixes a bug introduced in #21254 which caused existing contacts' email, address, phone, im to be updated incorrectly.

(The bug applies to Phone / Email / Address blocks with a singular location-type. Multi-address blocks are not affected.)

Before

To reproduce:

1. Log in and update your own contact record with > 1 email address
2. Set up an afform which pre-populates the current user
3. Add an email to the form. Set it to update "Primary" instead of "Multiple"
   
4. Use the form - your primary email will be updated but other emails will be deleted!

After

Fixed.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Did some r-run with a few different styles of "Email" and "Address" widgets:

• The "Multiple" style worked before and after patch.
• The "Primary" and "Billing" style were both problematic (deleting records from other locations) before the patch. After the patch, updates+deletes were properly focused on the specific location-type.
  • FWIW, if you have multiple records with the same location-type (eg two "Work" emails), then the outcome is somewhat arbitrary - eg for loading, the widget will show one; for saving, it will save the visible one and delete the other. It's kinda grey/debatable - it differs from the backend UI, but allowing only have one address per location-type is an easier mental-model... Regardless, the patch's behavior is clearly better than the prior behavior.

Tested on both 5.52-stable and 5.53-master.

Merging!