-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/core#3783 convert Recent Items providers into an option group #24164
Conversation
(Standard links)
|
Normally we try to write upgrade code in a way that's safe to be run multiple times. |
I've updated it. I figured eventually it would be in php, but as I was looking around it seemed like it would temporarily in |
@herbdool this looks good. The sql you wrote is still needed though, it just needs to be placed in |
@colemanw I added it to |
I tested this and added one additional safeguard. Everything else looks fine and works as expected. |
Overview
Fixes https://lab.civicrm.org/dev/core/-/issues/3783
Before
Recent Items providers is a hard-coded list.
After
Adds an option group and uses that instead.
I'm not quite sure if I've got the right place to put the upgrade query. I haven't tried it for core yet.