Remove loadAll parameter from loadRelatedObjects

[eileenmcnaughton]

Overview

Remove loadAll parameter from legacy function loadRelatedObjects

Before

loadAll parameter causes a couple of extra lines of code to run

After

The lines are moved to the caling functions

Technical Details

• I removed the setting of contact where we can see it is already set & the test check for financialType which is never otherwise used

Comments

test cover is good. The goal is to remove this function entirely...

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).