Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unshared function private, remove unused return #24105

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Make unshared function private, remove unused return

Before

Function not called from outside class, but public, return not used, but returned

After

private, no return

Technical Details

Comments

@civibot
Copy link

civibot bot commented Aug 1, 2022

(Standard links)

@civibot civibot bot added the master label Aug 1, 2022
@seamuslee001
Copy link
Contributor

Tests have passed and this seems fine to me

@seamuslee001 seamuslee001 merged commit 64964b6 into civicrm:master Aug 1, 2022
@seamuslee001 seamuslee001 deleted the priv branch August 1, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants