dev/core#3736 - Fix uploaded file on message template form

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/3736

Before

1. Admin - CiviMail - Message Templates
2. Add message template
3. Choose upload document for the Source.
4. Upload a document - just a simple Word doc is fine - the file itself doesn't seem to be the issue.
5. When you click "Save and Done" it doesn't get uploaded. It does work if you click "Save".

After

Good.

Technical Details

The button type needs to be upload.

Comments

See also

civicrm-core/CRM/Event/Form/ManageEvent.php

Lines 282 to 290 in b04fd95

	'type' => 'upload',
	'name' => ts('Save'),
	'isDefault' => TRUE,
	],
	[
	'type' => 'upload',
	'name' => ts('Save and Done'),
	'spacing' => '                 ',
	'subName' => 'done',

, so this is the same except there's no attachment over there but the point is you can have two upload buttons. I've refrained though from copying over the '                 ',, which as far as I can see doesn't do anything.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks!