Add upgrade for label to name conversion in civicrm_mapping_field for multiple custom imports
#23737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
civicrm_mapping_field for multiple custom imports
It wouldn't be that much more to go further & use the group.fieldname format - .... Add upgrade script to convert saved field mappings to use names
eileenmcnaughton
force-pushed
the
import_up_multi
branch
from
0777b10 to
5d0287e
Compare
totten
reviewed
Jun 9, 2022
| ->setSelect(['id', 'name']) | ||
| ->addWhere('mapping_id.mapping_type_id:name', '=', 'Import Multi value custom data') | ||
| ->execute(); | ||
| $allFields = civicrm_api3('custom_field', 'get', ['custom_group_id.is_multiple' => TRUE, 'return' => ['label', 'custom_group_id.title']])['values']; |
There was a problem hiding this comment.
Multiple high-level service calls... in the context of an upgrade... 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add upgrade for label to name conversion in
civicrm_mapping_fieldfor multiple custom importsBefore
Fields in saved import mappings for multiple custom imports won't load be picked up on latest code
After
Updated in upgrade from (eg.)
School Level :: "Educationtocustom_14Technical Details
Comments
I did r-run this