Remove a couple of non-test tests - syntax conformance #23715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove a couple of non-test tests - syntax conformance
Before
of the two tests removed
$params
array is no longer an error - it will instead be failing on no mandatory fields - which I feel is tested elsewhereAfter
poof
Technical Details
SyntaxConformanceTests
used to be really helpful - I feel like we now run too many for their value & they take a long time so a bit of a cull might be in order -Comments
Actually this one is probably more pointless