Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a couple of non-test tests - syntax conformance #23715

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 7, 2022

Overview

Remove a couple of non-test tests - syntax conformance

Before

of the two tests removed

  • one does an early return and no testing
  • maybe the other is useful - but it isn't testing what it says it is - since lack of $params array is no longer an error - it will instead be failing on no mandatory fields - which I feel is tested elsewhere

After

poof

Technical Details

SyntaxConformanceTests used to be really helpful - I feel like we now run too many for their value & they take a long time so a bit of a cull might be in order -

Comments

Actually this one is probably more pointless

image

@civibot
Copy link

civibot bot commented Jun 7, 2022

(Standard links)

@civibot civibot bot added the master label Jun 7, 2022
* @dataProvider entities
* @param $Entity
*/
public function testWithoutParam_create($Entity) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eileenmcnaughton I guess this is just testing that an APIv3 Exception or similar is thrown if no params are passed in right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - I think it would be a mandatory field validation error - perhaps it is of some value - but it just feels like we have too many of these tests now

@colemanw colemanw merged commit f7dd524 into civicrm:master Jun 8, 2022
@eileenmcnaughton eileenmcnaughton deleted the syntax branch June 8, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants