SearchKit - Remove confusing extra joins between Contact & Related Contacts

[colemanw]

Overview

The option to use RelationshipCache as a base entity was added in #23066 but a side-effect was the addition of some confusing extra join options. This fixes the side-effect.

Before

Selecting Contact as the base entity, there are 3 joins available to "Contact Related Contact"

After

Only one join available to related contacts.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[awestuk]

I think this patch removes 'Case Related Contacts' from Case Searches, which presumably it shouldn't...?

[colemanw]

@awestuk it's still there:

[awestuk]

Hrm, I can reliably make Case Related Contacts appear and disappear by applying this patch and clearing the cache. Maybe it's fixed in something subsequent.

[colemanw]

Oops, my screenshot was taken without the patch.
I see what you mean... but that doesn't actually belong there. Like the extra "Contact Related Contacts", it's confusing because it doesn't actually do what it says it does, it's a link to the Relationship Cache table, which we don't want, not a link through to the Contact table.
That's something we should add though.

[eileenmcnaughton]

Ok - this seems like how it was intended to work