Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import - ensure userID is set on parser #23636

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 31, 2022

Overview

Import - ensure userID is set on parser

Before

UserID not consistently set - increasing chances of creating bugs & fatal errors on the different imports

After

Consistency

Technical Details

Getting this in before the rc feels safer

Comments

I did some r-run on the various imports

@civibot
Copy link

civibot bot commented May 31, 2022

(Standard links)

@civibot civibot bot added the master label May 31, 2022

$mapperKeys = [];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see 2 rows further down

@eileenmcnaughton
Copy link
Contributor Author

@colemanw can I get a merge on this? It ensures that the datasource & userJob are consistently loaded - getting it in before the rc reduces the risk when porting fixes between the rc & master

@colemanw
Copy link
Member

colemanw commented Jun 1, 2022

Fix looks good.

@colemanw colemanw merged commit 094d703 into civicrm:master Jun 1, 2022
@colemanw colemanw deleted the import_contact_type branch June 1, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants