Test cleanup - use names keys in mapper array where possible for clarity #23627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_test
branch
from
73c19af to
8d68a71
Compare
eileenmcnaughton
force-pushed
the
import_test
branch
from
8d68a71 to
779b3ef
Compare
|
@yashodha - can you merge this too - seems it conflicts with other open ones so I'll have to rebase - but this one is passing.... |
|
@eileenmcnaughton sure, looks good, merging this! |
|
thanks @yashodha - I'll rebase it out of the others now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test cleanup - use names keys in mapper array where possible for clarity
Before
Even though core no longer uses the awful array of location types the tests still do
After
Tests use array which is like
civicrm_mapping_fieldTechnical Details
Comments