Import locations - code cleanup, add tests, fix bugs #23563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_location_all
branch
2 times, most recently
from
50a0e7e to
3267754
Compare
eileenmcnaughton
force-pushed
the
import_location_all
branch
10 times, most recently
from
da6cb93 to
2abcf7e
Compare
|
test this please |
|
last fails were unrelated (concurrency tests) - now falling over due to guzzle? test this please |
This fixes a couple of bugs I found writing tests & adds test cover for website & phone imports + cleanup Notably - creating a phone with a phone_ext or an email with signature_text doesn't work prior to this
eileenmcnaughton
force-pushed
the
import_location_all
branch
from
2abcf7e to
91a6950
Compare
|
OK, this is tested and fixes a regression. |
|
thanks @colemanw - that unblocks me! I'll work on the states |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Import locations - code cleanup, add tests, fix bugs
Before
After
Getting closer to the goal of
getParamsvalidateValuesgetParamsis doing a lot of itTechnical Details
Comments
In order to help with testing there are a bunch of csvs that I use over here - https://github.com/eileenmcnaughton/testdata/tree/master/csvs
Specifically useful to this PR is https://github.com/eileenmcnaughton/testdata/blob/master/csvs/individual_locations_with_related.csv
Along with javascript to create a mapping to get started....
https://github.com/eileenmcnaughton/testdata/blob/master/csvs/individual_locations_with_related.csv.js
(The js can be pasted directly into a Chrome or Firefox console - ie right-click inspect to get the console)