Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove always true if conditions (whitespace in next commit) #23533

Merged
merged 1 commit into from
May 23, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove always true if conditions (whitespace in next commit)

Before

if ($createNewContact || ($this->_updateWithId)) {

But we can see the first would only be FALSE if the second is TRUE

image

After

poof

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 21, 2022

(Standard links)

@civibot civibot bot added the master label May 21, 2022
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 @colemanw if one of you can merge this I'll follow up with the whitespace-fugly commit

@colemanw colemanw merged commit a458a7f into civicrm:master May 23, 2022
@colemanw colemanw deleted the import_if branch May 23, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants