Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to cover date field imports #23502

Merged
merged 3 commits into from
May 21, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This is the test cover for this extraction - #23498 - in the process I found that importing address custom fields with dates are currently broken - this has a fix for that. Note it also contains #23491 as the test utils in that were needed

@civibot civibot bot added the master label May 19, 2022
@civibot
Copy link

civibot bot commented May 19, 2022

(Standard links)

@eileenmcnaughton eileenmcnaughton force-pushed the import_test_ex branch 4 times, most recently from c7dc453 to e0a2045 Compare May 20, 2022 04:00
@eileenmcnaughton eileenmcnaughton force-pushed the import_test_ex branch 6 times, most recently from 712e703 to fe676cb Compare May 20, 2022 19:18
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton force-pushed the import_test_ex branch 2 times, most recently from 24b62ee to c432c67 Compare May 20, 2022 20:59
@colemanw
Copy link
Member

@eileenmcnaughton can you rebase this one?

@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw
Copy link
Member

@eileenmcnaughton php syntax error in tests/phpunit/CRM/Contact/Import/Parser/ContactTest.php

@eileenmcnaughton eileenmcnaughton merged commit 048517d into civicrm:master May 21, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_test_ex branch May 21, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants