Skip to content

[REF] [Import] Remove unused variable #23463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2022
Merged

[REF] [Import] Remove unused variable #23463

merged 1 commit into from
May 16, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] [Import] Remove unused variable

Before

Function is public but internal to the class & not used outside it (& logically would not be) and has an extraneous input

image

image

After

Method is private for clarity, $statusFieldName removed

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 14, 2022

(Standard links)

@civibot civibot bot added the master label May 14, 2022
@yashodha
Copy link
Contributor

@eileenmcnaughton looks good, merging this.

@yashodha yashodha merged commit 23519c6 into civicrm:master May 16, 2022
@yashodha
Copy link
Contributor

already remonved variable in #23462

@eileenmcnaughton eileenmcnaughton deleted the import_proc branch May 16, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @yashodha