Import validate related contacts in the same way as the main contact

[eileenmcnaughton]

Overview

Import validate related contacts in the same way as the main contact

This builds on #23424 - extending the required fields to related contact

Before

There is confusing / marginally successful validation code around related contacts - however in my testing there is an uncaught exception in 5.48 when the related contact has insufficient fields (e.g just source) and that is caught at the import stage in current master & logged as an error. In current master the main contact is imported but not the related one

After

The fields for the related contact are checked (& potentially rejected) at the validation stage using the same sub-routine as for the main contact

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

The new test coverage seems pretty useful.

I did r-run on a few different combinations of (valid,missing-field)x(original-contact,related-contact). Behavior seemed pretty sensible across them. Also ran the scenario from #23424 discussion, and it now produces the same result.

All tests passing.

To refactoring and beyond! 🚀

[eileenmcnaughton]

@totten yay - and now you can see how much code can go as a result of this one - #23461