[REF] APIv4 - Simplify entity creation in test suite #23432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Removes the old v3 creation and hardcoded sample data in favor of new `createTestRecord` and `saveTestRecords` methods which automatically handle cleanup during tearDown.
|
@eileenmcnaughton looks like this speeds up Jenkins PR test run by about 10 minutes :) |
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Makes the APIv4 test suite more efficient and easier to work with.
Before
Over-used and under-utilized sample data in json files, loading entire data set once-per-entity in the conformance test slows that test to a crawl.
Technical Details
Removes the old v3 creation and hardcoded sample data in favor of new
createTestRecordandsaveTestRecordsmethods which automatically supply required values and delete records during tearDown.