[Import] Use table rather than csvs for no-match & unparsed #23418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is being calculated here https://github.com/civicrm/civicrm-core/blob/c169525f72b1f956d58cec1e4a15b0f57de3eabf/CRM/Contact/Import/ImportJob.php#L132-L136 And this change moves the calculation into the parser class so that, along with the other arrays it can be removed as an input parameter
|
(Standard links)
|
eileenmcnaughton
changed the title
|
Tested on local, works fine. The added unit-test correctly capture the different parse errors and well defined pattern here |
|
yay - thanks @monishdeb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use table rather than csvs for no-match & unparsed
The user experience should be unchanged - ie importing the following file with a mapping of first_name, last_name, contact sub type should result in
contact_sub_type.csv
Before
CSVs for No match and 'unparsed' are compiled during import
After
The temp table is updated, as is done with errors, duplicates, and it downloadable on the summary form
Technical Details
This rips out a fair bit of code (yay) and also has tests for the full flow. It builds on other open PRs which can be rebased out if merged first
Comments