[Import] [Ref] [Minor] Simplify error handling with a try-catch block

[eileenmcnaughton]

Overview

[Import] [Ref] [Minor] Simplify error handling with a try-catch block

Before

Repetitve error handling & return points ...

multiple cases of

  array_unshift($values, $errorMessage);
  $this->setImportStatus($rowNumber, 'ERROR', $errorMessage);
  return CRM_Import_Parser::ERROR;

After

The code chunk is wrapped in a try-catch eg.

  try {

  }
  catch (CRM_Core_Exception $e) {
    array_unshift($values, $errorMessage);
    $this->setImportStatus($rowNumber, 'ERROR', $errorMessage);
    return CRM_Import_Parser::ERROR;
  }

Technical Details

use w=1 link as a fair bit of whitespace

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Seems fine to me