[REF][Import] (minor) Extract getHightlightedFields

[eileenmcnaughton]

Overview

[REF][Import] (minor) Extract getHightlightedFields

Before

Long block of code, switch...

After

Extracted function

Technical Details

• $contactType = $this->getContactType(); returns a word, $this->get('contactType') returns a constant
• self::$customFields is not used elsewhere
• the order of the fields doesn't matter - they are used in highLightImport.tpl

  var highlightedFields = ["{/literal}{'","'|implode:$highlightedFields}{literal}"];
  $.each(highlightedFields, function() {
    $('select[id^="mapper"][id$="_0"] option[value='+ this + ']').append(' *').css({"color":"#FF0000"});
  });

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Suggested change

	'Organization' => 'organization_name',
	'Organization' => ['organization_name'],
	'Household' => ['household_name'],

Otherwise you get
Error: [] operator not supported for strings in CRM_Contact_Import_Form_MapField->getHighlightedFields() when it tries to append email to the array, which is not an array.

[eileenmcnaughton]

opps! fixed

[demeritcowboy]

Also it's not from this PR but somewhere along the line the list of map fields has become always Individual fields. e.g. on dmaster.demo choose Organization as the type - the list on the mapfields page is for Individuals.

[eileenmcnaughton]

@demeritcowboy I can see where the other issue crept in - it will be easier to fix if I can get some of the other import PRs merged - but if they don't look to be merging in time for the rc I'll have to do a fix for just that.

[eileenmcnaughton]

I think this one in particular #23288 - would make it easier to do a good fix for the regression you found - since a lot of code can start to be unwound after that

[eileenmcnaughton]

thanks @demeritcowboy