Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/drupal#176 - Symfony cmf removed from drupal 10 #23302

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Apr 26, 2022

Overview

See https://www.drupal.org/node/3151009. This is the same as civicrm/cv#120.

https://lab.civicrm.org/dev/drupal/-/issues/176

Before

Error: Class "Symfony\Cmf\Component\Routing\RouteObjectInterface" not found when using cv in drupal 10.

After

Technical Details

Comments

This works in drupal 9 and 10 but not drupal 8, but drupal 8 been eol for 6 months and doesn't get security fixes and civi can be run equally as well on drupal 9.

@civibot
Copy link

civibot bot commented Apr 26, 2022

(Standard links)

@civibot civibot bot added the master label Apr 26, 2022
@demeritcowboy demeritcowboy changed the title Symfony cmf removed from drupal 10 dev/drupal#176 - Symfony cmf removed from drupal 10 Apr 26, 2022
@totten
Copy link
Member

totten commented Apr 27, 2022

r-run with bin/cli.php on D8. Confirmed that the conditional still works there. WRT D10, it seems pretty plausible, and I don't think we need to hold that aspect to strict scrutiny since D10-support is in middle-stages of development.

@totten totten merged commit 90ab56f into civicrm:master Apr 27, 2022
@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy deleted the symfony-cmf branch April 27, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants