[REF] [Import] Contribution import - clarify return codes #23290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
import_cont
branch
from
610f627 to
8926472
Compare
| * @return bool | ||
| * the result of this processing | ||
| */ | ||
| public function preview(&$values) { |
There was a problem hiding this comment.
Remove this & just call summary directly further down
eileenmcnaughton
force-pushed
the
import_cont
branch
from
8926472 to
bbd34c5
Compare
|
test this please |
eileenmcnaughton
force-pushed
the
import_cont
branch
from
bbd34c5 to
55ff389
Compare
…dling for unused CONFLICT
eileenmcnaughton
force-pushed
the
import_cont
branch
from
55ff389 to
5f97768
Compare
eileenmcnaughton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[REF] [Import] Contribution import - clarify return codes,
Before
It's unclear what return codes are in use
After
I went through & documented them on the 2 functions that return them
https://github.com/civicrm/civicrm-core/pull/23290/files#diff-a223445bfabeca3421466f7add0f896b2f7126287cbbd3124665781336f086d9R757-R764
and
https://github.com/civicrm/civicrm-core/pull/23290/files#diff-a223445bfabeca3421466f7add0f896b2f7126287cbbd3124665781336f086d9R721-R722
Technical Details
Comments