Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [Import] Activity - clean up copy & paste #23289

Merged
merged 1 commit into from
May 16, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

This class has a lot of handling for error codes but the 2 functions called

  • import() and summary() only error return valid or error - the rest of this handling is simply copy and paste
    from the contact import - which does indeed handle conflicts and duplicates and record them

Although there is handling for a function called internally to return a conflict this is converted to an error...

image

Note that the activity import does not off the option of duplicate handling - which is the context in which these error types are used in the contact import

image

@civibot
Copy link

civibot bot commented Apr 23, 2022

(Standard links)

@yashodha
Copy link
Contributor

yashodha commented May 9, 2022

@eileenmcnaughton Can you please resolve the conflicts for this one?

@eileenmcnaughton eileenmcnaughton force-pushed the import_summ branch 2 times, most recently from 4d9d6b9 to 53a9ddb Compare May 9, 2022 10:20
This class has a lot of handling for error codes but the 2 functions called
- import() and summary() only error return valid or error
@eileenmcnaughton
Copy link
Contributor Author

thanks @yashodha - it's rebased now

@yashodha
Copy link
Contributor

@eileenmcnaughton looks good,merging this.

@yashodha yashodha merged commit c819a4c into civicrm:master May 16, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_summ branch May 16, 2022 06:50
@eileenmcnaughton
Copy link
Contributor Author

thanks @yashodha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants