Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Do not treat site having a default location type as optional #23282

Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 21, 2022

Overview

[REF] Do not treat site having a default location type as optional

I found plenty of places where the code expects a response from
this function - just a couple of places in really old code
(like this) where it is optional....

For example - on the email edit form there is no allowance for there to be no default location type...

image

Before

Extraneous IF

After

One less point of confusion

Technical Details

Comments

@civibot
Copy link

civibot bot commented Apr 21, 2022

(Standard links)

@civibot civibot bot added the master label Apr 21, 2022
I found plenty of places where the code expects a response from
this function - just a couple of places in really old code
(like this) where it is optional....
@eileenmcnaughton eileenmcnaughton force-pushed the import_default_location_type branch from a03c1bf to 45a5074 Compare May 3, 2022 02:14
@eileenmcnaughton
Copy link
Contributor Author

test this please

@monishdeb
Copy link
Member

Agree with the patch, tested on the local, and don't find any regression on import.

@monishdeb monishdeb merged commit 1e31701 into civicrm:master May 5, 2022
@eileenmcnaughton eileenmcnaughton deleted the import_default_location_type branch May 5, 2022 19:41
@eileenmcnaughton
Copy link
Contributor Author

thanks @monishdeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants