Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor simplification of getAmountLevelText #23159

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Minor simplification of getAmountLevelText #23159

merged 1 commit into from
Apr 20, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 11, 2022 •
edited
Loading

Overview

Minor simplification of getAmountLevelText

Before

$displayParticipantCount is always NULL = silly
long code

After

shorter - poof

Technical Details

Only 1 non-test function call

image

Comments

@civibot
Copy link

civibot bot commented Apr 11, 2022

(Standard links)

@civibot civibot bot added the master label Apr 11, 2022
@eileenmcnaughton
Copy link
Contributor Author

@monishdeb could you look at this one - it's pretty trivial

@colemanw
Copy link
Member

Looks fine.

@colemanw colemanw merged commit 78c7e16 into civicrm:master Apr 20, 2022
@eileenmcnaughton eileenmcnaughton deleted the event branch April 20, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw