Paypal pro, a.net ipn - do not update start date, status

[eileenmcnaughton]

Overview

Paypal pro, a.net ipn - do not update start date, status

Before

• start_date updated on first paypal or ipn payment
• redundant update to contribution_recur.contribution_status_id

After

poof

Technical Details

On Follows on from #23081 we discussed whether start_date should be updated - I was of the opinion it should be standard behaviour & @mattwire made the case that paypal & a.net were outliers in updating the date.

The update to contribution_status_id traces back to here

civicrm/civicrm-svn@404e8bf

I STILL don't really understand the comment - however the BAO class ensures the status is updated to 'In Progress' when the first payment is converted to Completed

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).