Restrict allowed uploads - contact image

[braders]

Overview

Restrict allowed uploads - contact image

Before

The image upload for contacts accepted any file type. However, server-side logic restricted this within CRM_Contact_BAO_Contact::processImageParams.

After

Only allowed file types are allowed.

Comments

CRM_Contact_BAO_Contact::processImageParams actually accepts image/bmp, as well as aliases like image/x-png. All modern browsers will understand the accept value I have defined, and I really can't see anyone wanting to upload a bmp image in 2022! Therefore I went for a simplified list of mime types.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

This seems fine. There's a weird spacing in the error box if you try to upload a wrong file but I don't know where that popup is coming from and seems like a more general issue. P.S. I tried uploading this screenshot as a bmp but github won't take it (grin).