Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate MapTable.tpl #23138

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Consolidate MapTable.tpl #23138

merged 1 commit into from
Apr 8, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 8, 2022

Overview

Consolidate MapTable.tpl

Before

Three of the 5 MapFields.tpl files are almost identical

After

One file is shared

Technical Details

There are some minor markup changes - the most significant being that the classes include the entity name. My feeling was that having the same screen display consistently was more important than entity-specific classes

Also some classes had class="form-layout" and class=label & others didn't - so I added them

Comments

@civibot
Copy link

civibot bot commented Apr 8, 2022

(Standard links)

@civibot civibot bot added the master label Apr 8, 2022
@colemanw
Copy link
Member

colemanw commented Apr 8, 2022

Confirmed the import screen still works, and I think it's fine to use a generic class.

@colemanw colemanw merged commit 5ffc164 into civicrm:master Apr 8, 2022
@colemanw colemanw deleted the map branch April 8, 2022 12:40
@colemanw colemanw restored the map branch April 8, 2022 12:40
@colemanw colemanw deleted the map branch April 8, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants