dev/user-interface#26 Use font-awesome icons for contact types and recent items #23094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
added a commit
to civicrm/org.civicrm.recentmenu
that referenced
this pull request
Apr 3, 2022
CiviCRM core now supplies an 'icon' for each recent item, so there's no-longer a need to maintain a separate entity/icon list in this extension. See civicrm/civicrm-core#23094
|
|
colemanw
force-pushed
the
contactTypeIconUI
branch
from
3ba62ab to
78a4bac
Compare
This is an intermediary step toward removing the image_URL field. The UI now uses css-based icons when available, and only falls back to image_URL when an icon hasn't been set for a given sub-type. Fixes dev/user-interface#26
colemanw
force-pushed
the
contactTypeIconUI
branch
2 times, most recently
from
8a51561 to
49c63a6
Compare
|
Awesome! Reviewed and tested. All good to me. |
colemanw
added
the
merge ready
|
Thanks @samuelsov - having you test & review PRs is super helpful. |
colemanw
force-pushed
the
contactTypeIconUI
branch
from
49c63a6 to
3af57cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Display font-awesome icons instead of the old image gifs in the UI.
See dev/user-interface#26
Before
Contact type represented as gawdy gif.
Recent items sidebar uses gawdy gifs.
After
Contact type represented as a font-awesome icon.
Recent items sidebar updated to use font-awesome icons unless a contact sub-type still has
image_URLset. Activity type icons are also used if available.When editing a contact type, there is a new icon picker for selecting an icon. The
image_URLfield only appears if it contains a value, along with a deprecation warning. Otherwise the old field is hidden to prevent confusion.System status check added to prompt admins to pick icons for their contact types instead of images:
Technical Details
Uses the new ContactType
iconcolumn added in #23073 and the (relatively new)$_iconmetadata in each DAO.