Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect zero value #23016

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Respect zero value #23016

merged 1 commit into from
Apr 7, 2022

Conversation

pradpnayak
Copy link
Contributor

Overview

If the value or weight for the option value is set to 0, the edit screen still recalculates the value or weight.

@civibot
Copy link

civibot bot commented Mar 23, 2022

(Standard links)

@civibot civibot bot added the master label Mar 23, 2022
@eileenmcnaughton eileenmcnaughton added the merge ready PR will be merged after a few days if there are no objections label Apr 6, 2022
@eileenmcnaughton
Copy link
Contributor

@colemanw I've given this merge-ready just because you did tinker with it here https://github.com/civicrm/civicrm-core/pull/5538/files and I wanted to give you a chance to input.

I can see that

  1. value could definitely legitimately be 0 - we just try to ensure value has 'something' and
  2. it's a bit doubtful if 0 is legit for weight - but since it's not the default value it would only be 0 if delberately set to 0

@colemanw colemanw merged commit b991cdb into civicrm:master Apr 7, 2022
@colemanw
Copy link
Member

colemanw commented Apr 7, 2022

Seems fine to me.

@pradpnayak pradpnayak deleted the optionValue branch June 5, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants