Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix page size size #22927

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Conversation

colemanw
Copy link
Member

Overview

Shrinks the page size input to fit on smaller screens or dashboards.

Before

image

After

image

@civibot
Copy link

civibot bot commented Mar 10, 2022

(Standard links)

@demeritcowboy
Copy link
Contributor

A separate issue, but the page size size sizer seems inconsistent in what numbers it recognizes. For example if you put 5 in the box, it gives you more than 5. If you put 10 you get 10. Examples of other numbers are 3 (doesn't work) and 20 (works) and 15 (doesn't work).

@colemanw
Copy link
Member Author

Seems like the min="10" step="10" is causing that:
image

@demeritcowboy
Copy link
Contributor

Ah. I guess the table redraw mechanism picks up the new value before whatever makes that message comes up. I only get that message if I linger around the box but by then I'm clicking on other things.

@eileenmcnaughton eileenmcnaughton merged commit 1754e17 into civicrm:master Mar 10, 2022
@eileenmcnaughton eileenmcnaughton deleted the pagerSize branch March 10, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants