Core#2918 Implement new UI for configuring dedupe rule usage.

[braders]

Overview

This implements the new UI proposed and discussed in Core#2918.

Before

Currently the UI for configuring dedupe rules allows the usage to be selected from a list of radio options:

This is problematic for multiple reasons:

• It allows a situation where no supervised or unsupervised rule exists (A system check to warn against this was added in Add system status check for missing dedupe rules #22369).
• It incorrectly suggests that multiple supervised or unsupervised rules can be configured.
• The help text is somewhat squeezed into the helptext popup.

After

The UI is now driven through a popup allowing much more context into the available options:

It is no longer possible to change the usage for supervised and unsupervised rules - the "change usage" button is disabled, and the title attribute set to read "To change the usage for this rule, please configure another rule as Supervised":

Comments

Minor CSS adjustments have been made, which will affect non-default themes. However, without the CSS changes the functionality is still perfectly usable, so this shouldn't be a big issue.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[braders]

There seems to be style failures in civicrm.css that are not releated to my changes. Additionally the semi-colon failure on civicrm.css:1524 looks to be a failure of the stylechecker rather than a legitimate issue; I'm not the correct way to resolve that.

[seamuslee001]

Jenkins re test this please

[jaapjansma]

test this please

[jaapjansma]

@braders We are reviewing PR's and we came across this one. We checked the PR in the related test environment to this PR. However we could not click Change Usagge. Nothing happens when we click on that button. We tried it with an existing rule, a new rule in both cases nothing lets us change the Usage. Can you have another look?

[braders]

@jaapjansma Thanks for spotting that. It appears I was using Drupals outdated jQuery rather than CRM.$. I'll try and push a fix tonight or later this week.

[braders]

@jaapjansma This is now working correctly in the test environment.

[yashodha]

@braders this will address https://lab.civicrm.org/dev/core/-/issues/1769 as well

[BettyDolfing]

test this please

[jaapjansma]

• General standards
  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained in the PR.
  • User impact (r-user)
    • PASS: The change would be intuitive for a majority of users who work with this feature.
  • Documentation (r-doc)
    • PASS: We have checked the documentation and this still works as how it is explained in the documentation.
  • Run it (r-run)
    • PASS: We created and edited dedupe rules.
• Developer standards
  • Technical impact (r-tech)
    • PASS: The change preserves compatibility with existing callers/code/downstream.
  • Code quality (r-code)
    • PASS: The functionality, purpose, and style of the code seems clear+sensible.
  • Maintainability (r-maint)
    • PASS: The change is trivial enough that it does not require tests.
  • Test results (r-test)
    • PASS: The test results are all-clear.

@eileenmcnaughton or @seamuslee001 can one of you merge this PR?

[colemanw]

In general, CiviCRM has a problem with managing css. I certainly don't love adding lines to the global civicrm.css file just for the sake of one screen, but it's a pre-existing condition and at least what you added is well-commented.