Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PHP notices on activity form #22666

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 30, 2022

Overview

Avoid PHP notices on activity form.

This ensures that fallback values are set, so that notices are not thrown when activity.tpl does {if} checks on $activityTypeDescription and $activityTypeNameAndLabel.machineName.

Before

When creating a new activity (/civicrm/activity) a handful of PHP notices were generated from within Smarty templates.

After

No notices generated by core on this form.

@civibot
Copy link

civibot bot commented Jan 30, 2022

(Standard links)

@civibot civibot bot added the master label Jan 30, 2022
@braders braders force-pushed the avoid-php-notices-activity-form branch from 860543c to 8736ada Compare January 30, 2022 10:56
@braders braders force-pushed the avoid-php-notices-activity-form branch from 8736ada to 5aeca8c Compare January 31, 2022 20:20
@colemanw colemanw merged commit 5492bbc into civicrm:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants