Remove isset from online contribution receipt #22615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
online
branch
from
31bdc6b to
4c4cdb8
Compare
This removes the isset checks that re failing around totalTaxAmount (solved the same way as offline https://github.com/civicrm/civicrm-core/pull/22560/files#diff-fd5668d5492e5f0ec55b7f8a10eccfa4ea9de249e4cf2383a2e0d36dbd92ebe0R134 ) It also removes the isset around contribution.amount_level (switching to a token) and the enotice on isQuickConfig - this switches to loading that information & also using a more meaningful variable. Note that line items should always be assigned so that check is silly.
eileenmcnaughton
force-pushed
the
online
branch
from
4c4cdb8 to
9877040
Compare
|
@monishdeb if you are able to squeeze this into your review efforts it would be great.... (sql goes stale a lot) |
|
on it.. |
|
r-run passed on a new install and upgrade. There is no breakage on the online contribution receipt mail. Hence merging this PR. |
|
yay - thanks @monishdeb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove isset from online contribution receipt
Before
fatal errors in api_v3_ContributionTest with grumpy smarty (due to isset)
After
isset fails fixed....
Technical Details
This removes the isset checks that re failing around
totalTaxAmount (solved the same way as offline
https://github.com/civicrm/civicrm-core/pull/22560/files#diff-fd5668d5492e5f0ec55b7f8a10eccfa4ea9de249e4cf2383a2e0d36dbd92ebe0R134
)
It also removes the isset around contribution.amount_level (switching
to a token) and the enotice on isQuickConfig - this
switches to loading that information & also using a more meaningful variable.
Note that line items should always be assigned so that check is silly.
Comments
still some notices around soft credits - but will leave for a follow up