Improve financial trxn spec to require required fields #22571
Conversation
|
(Standard links)
|
|
@eileenmcnaughton the person who wrote this test is a huge fan of services, but I'm not wedded to it at all and am happy to drop it in favor of something more practical. |
eileenmcnaughton
force-pushed
the
trxn
branch
2 times, most recently
from
a2757ab to
a1037a2
Compare
eileenmcnaughton
force-pushed
the
trxn
branch
from
a1037a2 to
4609d08
Compare
|
api_v3_ContributionTest::testCreateUpdateContributionPaymentInstrument /home/jenkins/bknix-dfl/build/core-22571-7ma39/web/sites/all/modules/civicrm/tests/phpunit/api/v3/ContributionTest.php:4083 |
It turns out the apiv4 conformance test only passes because it is bypassing the BAO create method - which requires more parameters Not this will fail :-( because it messes with the test expectations - I don't know how to create complex valid test data for it though.... I guess we could create a contribution & pass it as entity_id
|
@colemanw @monishdeb I've finally brought this to a passing state .... |
|
|
Thanks @monishdeb - I'll see if that gets us past #23190 test fail! |
Overview
Improve financial trxn spec to require required fields
Before
It turns out the apiv4 conformance test only passes because it
is bypassing the BAO create method because of the mis-named BAO which @pradpnayak has been working on. The problem is ultimately that the test is not passing in the right parameters in part because the spec is not requiring all the parameters required at the BAO.
After
This updates the spec to be close to the v3 api requirements - it is still calling the wrong method but if we can get this to work then @pradpnayak's rename will work.
Technical Details
Not this will fail :-( because it messes with the test expectations
I guess we could create a contribution & pass it as entity_id - test conformance is hard
Comments
This is actually the first time I've ever gotten the v4 testConformance test to run locally :-). I hacked it per the patch below since it is never able to find the service - @colemanw why do we do the complicated, but hard to run, service config here - it doesn't seem to add much....