Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Update operator labels #22554

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

colemanw
Copy link
Member

Overview

Updates search kit labels to hopefully better describe ReGex

@civibot
Copy link

civibot bot commented Jan 18, 2022

(Standard links)

@civibot civibot bot added the master label Jan 18, 2022
@seamuslee001
Copy link
Contributor

Seems fine to me @mlutfy any objections?

@mlutfy
Copy link
Member

mlutfy commented Jan 18, 2022

I don't mean to nitpick, but why not "Regular Expression Matches" ?

  • despite SearchKit being a dev tool, "Reg Exp" is scary looking. Exp could be "exponent" or "explosive" :-)
  • if it's a space issue, I'd prefer Regex, because it's a more commonly used acronym, but keep in mind that most other languages do not use the term Regex, only the long form. French uses "Expression régulière", and I'm not sure how I would translate "No Regexp Match" (other than "Ne correspond pas à l'expression régulière").

Looking at my email filtering programs, a more common pattern is to have only "Contains" or "Does not contain", and then geeky people know they can use regexps (notable exception: in LibreOffice, it's a checkbox on the search options).

(when things are difficult to translate, it's often a sign that they are difficult to understand for most non-hardcore-dev English speakers)

@colemanw
Copy link
Member Author

@mlutfy there is already a "CONTAINS" operator, and yes there is a space issue so brevity is important. But maybe a less-technical term for Regex could be "Pattern"?

What about "Matches Pattern" / "Doesn't Match Pattern".

@mlutfy
Copy link
Member

mlutfy commented Jan 19, 2022

@colemanw Works for me. Thanks!

@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label Jan 19, 2022
@eileenmcnaughton eileenmcnaughton merged commit c5df25a into civicrm:master Jan 20, 2022
@eileenmcnaughton eileenmcnaughton deleted the searchKitOps branch January 20, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants