Stop calling confusing function that doesn't do much .....

[eileenmcnaughton]

Overview

Stop calling confusing function that doesn't do much .....

Before

call to CRM_Contact_BAO_Relationship::setContactABFromIDs is super confusing - but it turns out it only
does

$contactFields = [
      'contact_id_a' => $contactID,
      'contact_id_b' => $organizationID,
      'relationship_type_id' => $relationshipTypeID,
    ];

After

Just formats the array directly

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw @seamuslee001 could one of you merge this one?

[seamuslee001]

ok I stepped through this and agree that this is correct

[eileenmcnaughton]

thanks @seamuslee001