dev/core#983 Fix Access CiviCampaign permissions (instead of admin)

[mlutfy]

Overview

https://lab.civicrm.org/dev/core/-/issues/983

and https://civicrm.stackexchange.com/questions/24409/whats-the-expected-behaviour-for-civicampaign-and-permissions

It's not possible for users without "administer CiviCampaign" to search/access some campaign activities.

Before

Non-admins cannot search for campaign data.

After

non-admins can search/view campaign data.

Comments

I have to admit that I have worked on this a while ago, patched locally and forgot about it. We have been running the patch in production for the past 2 years. A few NDI users required this feature, so I think it's well-tested.

ping @francescbassas @andyburnsco @pfigel (folks who commented on the gitlab issue)

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[andyburnsco]

I've tested this and the campaign field shows up in search screens as well as when adding relevant entities e.g. a contribution when granting the permissions manage campaign. Progress :)

I still feel something is not right, though. administer CiviCampaign and manage campaign are quite close to each other in what they do. I think a more baseline permission level is needed, which may be a separate PR etc.

CiviCampaign: administer CiviCampaign
Create new campaign, survey and petition types and their status

CiviCampaign: manage campaign
Create new campaigns, surveys and petitions, reserve respondents

It seems appropriate that there would be an access civicampaign permission for users who just need to search campaigns. Ideally we'd go further and limit who could edit campaigns on entities but for now I'd say it is okay to group search and add/edit into one permission.

[colemanw]

In order to not let perfect be the enemy of good, I'm going to merge this, noting that follow-up work is still needed to add an "access CiviCampaign" permission to the system (also noting that a volunteer hasn't yet stepped up to do that work, but would be very welcome).

[andyburnsco]

Yeah this was an quick win to get out of the way. We're looking to fund some further work on it and are starting those talks. Thanks :)