Enotice fix #22436
Merged
Enotice fix #22436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
reviewed
Jan 9, 2022
| @@ -75,17 +75,17 @@ CRM.$(function($) { | |||
| }); | |||
| function assignRemove(recordID, op) { | |||
| var recordBAO = 'CRM_Batch_BAO_Batch'; | |||
| if (op == 'assign' || op == 'remove') { | |||
| recordBAO = 'CRM_Batch_BAO_EntityBatch'; | |||
| if (op === 'assign' || op === 'remove') { | |||
There was a problem hiding this comment.
@eileenmcnaughton does === do the same thing in JS as in php?
There was a problem hiding this comment.
@seamuslee001 I think so since it was my IDE that wanted this change
There was a problem hiding this comment.
@seamuslee001 seems to be working fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The form conditionally adds the export & close buttons to the template. The template does a check before adding the close button, and not before adding the export button. However, the conditional it DOES apply (checking status) is also applied by the form - so better to just check if it is applied.
Before
After
Technical Details
The buttons are not applied due to permissions - I think the demo user should have the ability to see these buttons & will do a PR to that effect
Comments
civicrm/civicrm-buildkit#666 adds the permissions