Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Stop calling hook twice
Before
Relationship pre hook called twice on import & when creating current employer (and a JMA extension)
After
Only called once - per standard behaviour
Technical Details
Per the code comments this hook is called here but also in add. This is all about the crazy
history of this function - which used to be tied to the relationship form.
I can't think of any valid use for calling the hook twice - but I can think of reasons it
would be bad...
Comments
I added a note to the change log on this one https://lab.civicrm.org/documentation/docs/dev/-/blob/master/docs/hooks/changes.md