PHP 8 compat - no optional param before required #22210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PHP 8 doesn't allow optional params before required params. This param is unused so I removed it
Technical Details
Jenkins won't allow any commits that modify this file until this is fixed.
Comments
I considered simply making it required given that it's only called with
FALSE
but since it's unused and unlikely to get used any time soon (I don't even understand its intent), I'm just removing it.