Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 compat - no optional param before required #22210

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

MegaphoneJon
Copy link
Contributor

Overview

PHP 8 doesn't allow optional params before required params. This param is unused so I removed it

Technical Details

Jenkins won't allow any commits that modify this file until this is fixed.

Comments

I considered simply making it required given that it's only called with FALSE but since it's unused and unlikely to get used any time soon (I don't even understand its intent), I'm just removing it.

@civibot
Copy link

civibot bot commented Dec 3, 2021

(Standard links)

@demeritcowboy
Copy link
Contributor

Agreed. Could also remove the comment on line 181/179 but is fine as-is.

@seamuslee001
Copy link
Contributor

test fail unrelated

@seamuslee001 seamuslee001 merged commit 291669e into civicrm:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants