APIv4 - Delete unused OptionList trait #22158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trait had been added for the sake of SearchKit to determine which entities should be searchable and which were merely supplying option lists for other entities. However, this logic broke down quickly as some option lists *should* be searchable, so that path was abandoned in favor of the `@searchable` annotation. The trait now does nothing and is just taking up space and adding unnecessary complexity.
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Deletes some unused code from APIv4
Technical Details
This trait had been added for the sake of SearchKit to determine which entities should be searchable and which were merely supplying option lists for other entities.
However, this logic broke down quickly as some option lists should be searchable, so that path was abandoned in favor of the
@searchableannotation.The trait now does nothing and is just taking up space and adding unnecessary complexity.