Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabs getting overwritten by double foreach loop #22040

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

colemanw
Copy link
Member

Overview

This resolves issues with tabs on the contact view page randomly disappearing or duplicating.
Alternative to #22039

Technical Details

There were two foreach loops using the same variable, which was passed to the first by reference.

@civibot
Copy link

civibot bot commented Nov 11, 2021

(Standard links)

@demeritcowboy
Copy link
Contributor

I came across this separately: https://lab.civicrm.org/dev/core/-/issues/2952

Patch works for me.

@demeritcowboy demeritcowboy merged commit 9d73b56 into civicrm:master Nov 11, 2021
@eileenmcnaughton eileenmcnaughton deleted the expectedKeys branch November 11, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants