Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] dev/report#77 - contribute/history civireport seems ok to run during reporttemplatetest #22015

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

At one time there was a function signature issue. Seems fine now.

Before

After

yet another test

Technical Details

Comments

The other skipped test still has an error but it's different than the listed error so updated the text.

@civibot
Copy link

civibot bot commented Nov 9, 2021

(Standard links)

@seamuslee001
Copy link
Contributor

@demeritcowboy test fail relates

api_v3_ReportTemplateTest::testReportTemplateSelectWhere with data set #26 ('contribute/history')
Failure in api call for report_template getrows:  DB Error: no such field
 SELECT contact_civireport.id as cid, SUM(contribution_civireport.total_amount) as civicrm_contribution_total_amount_sum 
        FROM civicrm_contact  contact_civireport
             INNER JOIN civicrm_contribution   contribution_civireport
                     ON contact_civireport.id = contribution_civireport.contact_id AND
                        contribution_civireport.is_test = 0 AND
                        contribution_civireport.is_template = 0 WHERE ( contribution_civireport.contribution_status_id IN (1) ) AND (`contact_civireport`.`contact_type` IS NULL OR (`contact_civireport`.`contact_type`  =  'Organization' )) AND (`relationship_civireport`.`contact_id_a` IS NULL OR (`relationship_civireport`.`contact_id_a` IN (SELECT `id` FROM `civicrm_contact` WHERE contact_type  =  'Organization' ))) AND (`relationship_civireport`.`contact_id_b` IS NULL OR (`relationship_civireport`.`contact_id_b` IN (SELECT `id` FROM `civicrm_contact` WHERE contact_type  =  'Organization' )))   GROUP BY contact_civireport.id   LIMIT 25 [nativecode=1054 ** Unknown column 'relationship_civireport.contact_id_a' in 'where clause']
                        ```

@demeritcowboy
Copy link
Contributor Author

Strange it ran fine locally. It was mariadb but I don't think that would be a difference here. Hmm....

@demeritcowboy
Copy link
Contributor Author

Oh I see - there are two tests that use the list. I only ran one of them. So now this updated PR only adds one test instead of two but 'tis better than none.

@seamuslee001 seamuslee001 merged commit 4708983 into civicrm:master Nov 10, 2021
@demeritcowboy demeritcowboy deleted the test-histreport branch November 10, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants