dev/core#2550 Fix possible upgrade failures #21997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yet exist Fixes dev/core#2550
|
(Standard links)
|
This was referenced Nov 6, 2021
|
@colemanw @eileenmcnaughton should I create a 5.43 rc PR for this patch as its more generic solution to the current problem and close #21996 ? |
|
@monishdeb can you confirm this patch fixes the bug? |
|
@colemanw I think monish did that in his comment here #21984 (comment) |
|
Ok, in that case this can be merged and here is the backport PR: #21999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the upgrade bug reported in https://lab.civicrm.org/dev/core/-/issues/2550
Before
Upgrade fails for 5.15 -> 5.36
After
This ought to fix it
Technical Details
This replaces #21984 with a more generic solution