Reporting #18: Fix sorting with > 10 participant roles

[MegaphoneJon]

https://lab.civicrm.org/dev/report/-/issues/18

Overview

This is based on the feedback in #14982.

To replicate this bug, you need at least ten participant roles. The first one's value should be 1. Searching on this value will return any participant whose role BEGINS with a 1 (i.e. 10, 11, 100, etc.) rather than just records whose participant role value IS 1.

Before

Searching for a participant role will return all participants whose value begins with the value you're searching for.

After

Participant list is filtered correctly.

Technical Details

This report had an overridden where() method to filter is_test, but as @yashodha pointed out on #14982, this isn't a very good way to handle this.

Comments

I've been carrying #14982 as a custom patch for 2 years, I realized that the proper fix wasn't all that hard after all. The parent where() has been refactored a couple of times so it was a bit of work to trace through, but it all looks correct.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I'm gonna merge this because as @eileenmcnaughton pointed out in #14982 the overridden function you're removing has no test cover whereas the parent function does, and 2 years is a long time to use it in production with no problems!