Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct CMS name on profile UF group types #21900

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Correct CMS name on profile UF group types #21900

merged 1 commit into from
Oct 21, 2021

Conversation

herbdool
Copy link
Contributor

Overview

Fixes https://lab.civicrm.org/dev/backdrop/-/issues/2

Before

Says "Drupal User Registration" on Profile options.

After

Says either "Backdrop User Registration" or "Drupal User Registration" as appropriate.

Technical Details

New method on CRM_Utils_System_*

@civibot
Copy link

civibot bot commented Oct 21, 2021

(Standard links)

@civibot civibot bot added the master label Oct 21, 2021
@MegaphoneJon
Copy link
Contributor

I just looked this over from a code review perspective, and it looks good, and matches the approach I mentioned on the related Gitlab ticket.

Since it's a new method, we may want to add return type hinting (i.e: function getUfGroupTypes() : array {) but I certainly wouldn't block a merge on that.

Since this is a CMS-specific patch, I tested it across Backdrop/D7/WP/D9. The changes were what I'd expect - only Backdrop changed. I actually thought this would fix the bogus WP UF group types. It didn't, but that's out of scope here.

Before

Backdrop

Selection_1264

D7

Selection_1265

WP

Selection_1266

D9

Selection_1270

After

Backdrop

Selection_1267

D7

Selection_1268

WP

Selection_1269

D9

Selection_1271

@eileenmcnaughton eileenmcnaughton merged commit 8f0e98f into civicrm:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants