Entity types hook recursion fix

[colemanw]

Overview

Follow-up to #21828 for avoiding recursion when subscribing to the new civi.api4.entityTypes event and calling the API within the subscriber

Before

Uses API in a function called by APIv4 Entity.get. Recursion.

After

Cleaned up to fix a fixme and not call the api recursively.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@jensschuppe can you confirm this addresses the issue you hit?

[jensschuppe]

@jensschuppe can you confirm this addresses the issue you hit?

@eileenmcnaughton Yes, I can confirm.

[colemanw]

@eileenmcnaughton this also fixes a fixme you left in the comments :)

[eileenmcnaughton]

@colemanw I'm happy to merge this - but I kinda wonder about casting those strings back to null?

[colemanw]

@eileenmcnaughton the reason I removed that bit is because I thought it was over-zealous casting. There's no practical difference.

[eileenmcnaughton]

ok