Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#2836) regen.sh - Fix incorrect reference to "flexmailer". Update data file. #21830

Merged
merged 2 commits into from
Oct 14, 2021

Conversation

totten
Copy link
Member

@totten totten commented Oct 14, 2021

Overview

The sample data used on dev sites comes from civicrm_generated.mysql and the generator-script, regen.sh. The generator includes a filter to restrict the set of civicrm_extensions that may appear in the sample data. The list has a typo.

This is a follow-up to fix an issue with #21522. ping @eileenmcnaughton

Before

The filter matches full_name to flexmailer, which is not really the full name.

If you install a new site using sample data, then flexmailer is inactive.

After

Use the real full_name.

If you install a new site using sample data, then flexmailer is active.

The script tries to filter the list of extensions that wind up in the sample data-set.

The filter list targets `full_name` (ie long name), but some of the values are inaccurate.
@civibot
Copy link

civibot bot commented Oct 14, 2021

(Standard links)

@civibot civibot bot added the 5.43 label Oct 14, 2021
@totten totten merged commit c9bb3b4 into civicrm:5.43 Oct 14, 2021
@totten totten deleted the 5.43-regen branch October 14, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants