dev/core#2907 fix for gdpr clobering contact tokens

[eileenmcnaughton]

Overview

This is a fix for contact tokens not rendering when gdpr tokens is installed - https://github.com/veda-consulting-company/uk.co.vedaconsulting.gdpr

Gdpr declares some addtional tokens with the namespace 'contact'. I am inclined to
agree with @magnolia61's suggestion it is 'naughty' and so while I have fixed the clobbering by
not processing contact-metadata tokens I have not fixed the enotices.

If we think it is non-naughty I can kill those - but I've already loosened
some strictness that I think had benefits in order to facilitate this

Before

Contact tokens don't render with gdpr extension installed. This extension declares tokens in the 'contact' namespace such as {contact.comm_pref_supporter_link}

After

Technical Details

Comments

Thanks for the testing / diagnosis @magnolia61

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[magnolia61]

Using this patch solved the problem partially:

With the gdpr extension disabled:

fields like birthday, city and email still didn't work with this patch. Will try to test some more

[eileenmcnaughton]

@magnolia61 thanks - I'll test those fields specifically

[eileenmcnaughton]

@magnolia61 I think I've fixed it

[magnolia61]

@eileenmcnaughton you've fixed it

[eileenmcnaughton]

yay - @colemanw can you MOP this based on testing - it's an rc regression

[eileenmcnaughton]

although @colemanw I should note there is a question about the 'naughty & nice' thing - around e-notices

[seamuslee001]

so @eileenmcnaughton I suppose this begs the question but is probably answered by your PR description but are we explicitly meant to be blocking people from using contact, event, participant etc categories in their extensions e.g. coming up with their own custom tokens or is it just that GDPR is doing something rather badly?

[eileenmcnaughton]

@seamuslee001 yeah - so this change means that it will work if they do that - but there will be e-notices. I've landed on 'discourage but don't block' - ie let the notices happen

[eileenmcnaughton]

@seamuslee001 I just tested with civitoken which polutes the 'contribution' namespace in tokens (although it's a bit different since hookTokens is really about contact tokens) and the notices only apply to pollution of the contact namespace

[magnolia61]

first_name, last_name, birth_date and job_title still do not seem to render in combination with the gdpr extension enabled

[eileenmcnaughton]

@magnolia61 I just tested this from contact search + pdf letter task with gdpr enabled & the 4 fields rendered

[magnolia61]

With me these 4 fields (first_name, last_name, birth_date and job_title) still do not render when gdpr is installed.
I am using scheduled reminders to test that.

But I do not think it should be fixed here, I think in a new release GDPR could adopt to a better way of token-handling.